Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOCOM-1221] Changed deploy pipeline and healthcheck path #80

Merged
merged 42 commits into from
Apr 16, 2024
Merged

[#IOCOM-1221] Changed deploy pipeline and healthcheck path #80

merged 42 commits into from
Apr 16, 2024

Conversation

michaeldisaro
Copy link
Contributor

@michaeldisaro michaeldisaro commented Apr 2, 2024 •
edited
Loading

List of Changes

Changed deploy pipeline to deploy on plain azure functions.

Motivation and Context

We need to deploy these functions outside AKS.

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@michaeldisaro michaeldisaro requested a review from a team as a code owner April 2, 2024 14:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-1221

@michaeldisaro michaeldisaro changed the title [#IOCOM-1221] Added github actions to release and deploy [#IOCOM-1221] Changed deploy pipeline and healthcheck path Apr 3, 2024
lucacavallaro
lucacavallaro reviewed Apr 3, 2024
View reviewed changes
.github/workflows/actions/build.yaml Outdated Show resolved Hide resolved
.github/workflows/actions/build.yaml Outdated Show resolved Hide resolved
.github/workflows/actions/build.yaml Outdated Show resolved Hide resolved
.github/workflows/actions/create-artifact.yaml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (2a2ef40) to head (d9e5313).
Report is 335 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   92.85%   84.16%   -8.69%     
==========================================
  Files          15       23       +8     
  Lines         252      499     +247     
  Branches       20       31      +11     
==========================================
+ Hits          234      420     +186     
- Misses         18       78      +60     
- Partials        0        1       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lucacavallaro
lucacavallaro requested changes Apr 3, 2024
View reviewed changes
.github/actions/create-artifact/action.yml Outdated Show resolved Hide resolved
.github/actions/create-artifact/action.yml Outdated Show resolved Hide resolved
.github/actions/build/action.yml Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@michaeldisaro michaeldisaro merged commit a395906 into master Apr 16, 2024
5 checks passed
@michaeldisaro michaeldisaro deleted the iocom-1221 branch April 16, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Krusty93 Krusty93 Krusty93 left review comments

@lucacavallaro lucacavallaro lucacavallaro approved these changes

@pagopa-github-bot pagopa-github-bot Awaiting requested review from pagopa-github-bot pagopa-github-bot was automatically assigned from pagopa/io-backend-contributors

@rodoviti rodoviti Awaiting requested review from rodoviti rodoviti was automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaeldisaro @codecov-commenter @lucacavallaro @Krusty93